-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add two examples for karmada deploy workloads #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide the link to the example here?
@@ -0,0 +1,3 @@ | |||
**Summary** | |||
|
|||
In this scenario, we will learn how to deploy workloads across multiple clusters. More specifically, use propagationPolicy and staticWeight to divide nginx deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the following description:
In this scenario, we'll learn how to deploy workloads across multiple clusters using PropagationPolicy with StaticWeight configuration to divide the nginx deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yours description better
@@ -0,0 +1,156 @@ | |||
#!/usr/bin/env bash | |||
|
|||
set -o errexit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to give the directory name karmada-division-deploy-example
.
@@ -0,0 +1,3 @@ | |||
**Summary** | |||
|
|||
In this scenario, we learned how to deploy workloads across multiple clusters. More specifically, use the propagationPolicy and duplicate modes to deploy nginx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -0,0 +1,147 @@ | |||
#!/usr/bin/env bash | |||
|
|||
set -o errexit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to give the directory name karmada-duplicate-deploy-example
}, | ||
{ | ||
"title": "Create propagationPolicy and deploy pods", | ||
"text": "step3/text.md", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create propagationPolicy and deploy deployment
``` | ||
2. Check whether the member cluster has been joined | ||
|
||
RUN `kubectl --kubeconfig /etc/karmada/karmada-apiserver.config get cluster`{{exec}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a note here (because it may make users confused why checking failed):
PS: Initializing the testing environment may take a few minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
|
||
create deployment named nginx | ||
|
||
RUN `kubectl --kubeconfig /etc/karmada/karmada-apiserver.config create -f ~/nginx/nginxDeployment.yaml`{{exec}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apply
is a better choice, it could be applied multiple times without error:
kubectl --kubeconfig /etc/karmada/karmada-apiserver.config apply -f ~/nginx/nginxDeployment.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
@@ -0,0 +1,3 @@ | |||
#!/bin/bash | |||
|
|||
kubectl --kubeconfig /etc/karmada/karmada-apiserver.config get deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification can be passed even if the deployment has not been created yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl --kubeconfig /etc/karmada/karmada-apiserver.config get deployment nginx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other looks good to me.
@@ -0,0 +1,3 @@ | |||
**Summary** | |||
|
|||
In this scenario, we'll learn how to deploy workloads across multiple clusters using PropagationPolicy with StaticWeight configuration to divide the nginx deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this scenario, we learned how xxxx
@@ -0,0 +1,3 @@ | |||
**Summary** | |||
|
|||
In this scenario, we'll learn how to deploy workloads across multiple clusters using PropagationPolicy to duplicate the nginx deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
cc @RainbowMango for checking |
7a51b43
to
352d797
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
I will add it to my queue and will try to review it by the end of this week.
@@ -0,0 +1,36 @@ | |||
{ | |||
"title": "deploy workload through karmada duplicated type", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is based on technology, perhaps it would be better to use a description that reflects value.
Such as
HA workload deployment
@@ -0,0 +1,36 @@ | |||
{ | |||
"title": "deploy workload through karmada divided type", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the other sceanrio. People might not interested in the propagation mode is divided
or duplicated
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title field will be in the Killercoda sceanrio name. If the previous one is called HA workload deployment
, then this one should be different from the previous one's name
56543e5
to
3b4e320
Compare
Signed-off-by: zhangdiandian <1635468471@qq.com>
I think this description is ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: [JadeFlute0127] [1635468471@qq.com]
What this PR does / why we need it:
add two examples for karmada deploy workloads
Which issue(s) this PR fixes:
Part of #1
Special notes for your reviewer:
Does this PR introduce a user-facing change?: